netdev - Re: [PATCH net] rxrpc: Fix potential data race in rxrpc_wait_to_be

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Apr 2023 08:10:19 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     David Howells <dhowells@...hat.com>
Cc:     netdev@...r.kernel.org,
        syzbot+ebc945fdb4acd72cba78@...kaller.appspotmail.com,
        marc.dionne@...istor.com, dvyukov@...gle.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        linux-afs@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix potential data race in
 rxrpc_wait_to_be_connected()

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Tue, 25 Apr 2023 13:56:35 +0100 you wrote:
> Inside the loop in rxrpc_wait_to_be_connected() it checks call->error to
> see if it should exit the loop without first checking the call state.  This
> is probably safe as if call->error is set, the call is dead anyway, but we
> should probably wait for the call state to have been set to completion
> first, lest it cause surprise on the way out.
> 
> Fix this by only accessing call->error if the call is complete.  We don't
> actually need to access the error inside the loop as we'll do that after.
> 
> [...]

Here is the summary with links:
  - [net] rxrpc: Fix potential data race in rxrpc_wait_to_be_connected()
    https://git.kernel.org/netdev/net/c/2b5fdc0f5caa

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html