netdev - Re: [PATCH v4 2/2] pinctrl: qcom: Add SDX75 pincontrol driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Apr 2023 16:37:11 +0530
From:   Rohit Agarwal <quic_rohiagar@...cinc.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <linus.walleij@...aro.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <richardcochran@...il.com>, <manivannan.sadhasivam@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 2/2] pinctrl: qcom: Add SDX75 pincontrol driver


On 4/27/2023 4:24 PM, Andy Shevchenko wrote:
> On Thu, Apr 27, 2023 at 11:53 AM Rohit Agarwal
> <quic_rohiagar@...cinc.com> wrote:
>> On 4/26/2023 10:12 PM, Andy Shevchenko wrote:
>>> On Wed, Apr 26, 2023 at 6:18 PM Rohit Agarwal <quic_rohiagar@...cinc.com> wrote:
>>>> On 4/26/2023 8:34 PM, andy.shevchenko@...il.com wrote:
> ...
>
>>>> Ok, Will update this. Shall I also update "PINGROUP" to "PINCTRL_PINGROUP"?
>>> Yes, please.
>> PINCTRL_PINGROUP cannot be used as it is, since msm_pigroup has multiple
>> other fields that needs to be set
>> for each pingroup defined.
>> Would rename this to SDX75_PINGROUP, as seen on some other platforms.
>> Would that be ok?
> For this patch, yes. But can you create a separate followup that
> replaces three members of struct msm_pingroup by embedding struct
> pingroup into it? There are examples of such changes in the kernel
> already. https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/drivers/pinctrl?id=39b707fa7aba7cbfd7d53be50b6098e620f7a6d4
>
Sure, create a separate followup patch referring it. Will use 
SDX75_PINGROUP for now.
Thanks,
Rohit.