netdev - Re: [RFC PATCH v4 3/5] Add ndo_hwtstamp_get/set support to vlan/maxvlan code path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP5jrPE-mQ33PGfX4vGtDfn_WU7wM-ZJBw9dGO7JrPJfxh8x8w@mail.gmail.com>
Date:   Wed, 26 Apr 2023 22:07:47 -0600
From:   Max Georgiev <glipus@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     kory.maincent@...tlin.com, netdev@...r.kernel.org,
        maxime.chevallier@...tlin.com, vladimir.oltean@....com,
        vadim.fedorenko@...ux.dev, richardcochran@...il.com,
        gerhard@...leder-embedded.com
Subject: Re: [RFC PATCH v4 3/5] Add ndo_hwtstamp_get/set support to
 vlan/maxvlan code path

On Wed, Apr 26, 2023 at 8:37 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 25 Apr 2023 22:43:34 -0600 Max Georgiev wrote:
> > > On Sat, 22 Apr 2023 21:28:35 -0600 Maxim Georgiev wrote:
> > > > -             if (!net_eq(dev_net(dev), &init_net))
> > > > -                     break;
> > >
> > > Did we agree that the net namespace check is no longer needed?
> > > I don't see it anywhere after the changes.
> >
> > My bad, I was under the impression that you, guys, decided that this
> > check wasn't needed.
> > Let me add it back and resend the patch.
>
> My memory holds for like a week at best :)
> I was genuinely asking if we agreed, if we did just mention that
> in the commit msg and add a link to the discussion :)

I looked through the discussion between you and Vladimir on vlan
and maxvlan driver conversion - there were no comments on the namespace
check
(https://lore.kernel.org/netdev/20230406165055.egz32amam6o2bmqu@skbuf/T/)
I guess I was delusional by excluding this check - thank you for catching it!