netdev - Re: [PATCH net] sfc: Fix module EEPROM reporting for QSFP modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67ecea44-2190-4aa4-9439-6e24013674c0@lunn.ch>
Date:   Fri, 28 Apr 2023 16:01:34 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Andy Moreton <andy.moreton@....com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Edward Cree <ecree.xilinx@...il.com>,
        Martin Habets <habetsm.xilinx@...il.com>
Subject: Re: [PATCH net] sfc: Fix module EEPROM reporting for QSFP modules

On Fri, Apr 28, 2023 at 12:33:33PM +0100, Andy Moreton wrote:
> The sfc driver does not report QSFP module EEPROM contents correctly
> as only the first page is fetched from hardware.
> 
> Commit 0e1a2a3e6e7d ("ethtool: Add SFF-8436 and SFF-8636 max EEPROM
> length definitions") added ETH_MODULE_SFF_8436_MAX_LEN for the overall
> size of the EEPROM info, so use that to report the full EEPROM contents.

For backporting in stable, a minimal fix this like is O.K.

For net-next, it would be better to implement the ethtool op
get_module_eeprom_by_page(). This takes all the logic for identifying
the SFP type out of the kernel driver, and allows user space to access
any page of any SFP.

See the Mellanox drive for an example.

    Andrew