netdev - Re: [PATCHv2 net 3/4] selftests: forwarding: lib: add netns support for tc rule handle stats get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZEwnqMyZjJJy3ZNg@corigine.com>
Date:   Fri, 28 Apr 2023 22:08:08 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Liang Li <liali@...hat.com>, Vincent Bernat <vincent@...nat.ch>
Subject: Re: [PATCHv2 net 3/4] selftests: forwarding: lib: add netns support
 for tc rule handle stats get

On Thu, Apr 27, 2023 at 11:39:08AM +0800, Hangbin Liu wrote:

Hi Hangbin,

a commit description should go here.
F.e. explaining why this change is being made.

> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  tools/testing/selftests/net/forwarding/lib.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
> index d47499ba81c7..426bab05fe0a 100755
> --- a/tools/testing/selftests/net/forwarding/lib.sh
> +++ b/tools/testing/selftests/net/forwarding/lib.sh
> @@ -773,8 +773,9 @@ tc_rule_handle_stats_get()
>  	local id=$1; shift
>  	local handle=$1; shift
>  	local selector=${1:-.packets}; shift
> +	local netns=${1:-""}; shift
>  
> -	tc -j -s filter show $id \
> +	tc $netns -j -s filter show $id \
>  	    | jq ".[] | select(.options.handle == $handle) | \
>  		  .options.actions[0].stats$selector"
>  }
> -- 
> 2.38.1
>