[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZEww7uBf5HYy7AqP@corigine.com>
Date: Fri, 28 Apr 2023 22:47:42 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, jarkko.nikula@...ux.intel.com,
andriy.shevchenko@...ux.intel.com, mika.westerberg@...ux.intel.com,
jsd@...ihalf.com, ose.Abreu@...opsys.com, andrew@...n.ch,
hkallweit1@...il.com, linux@...linux.org.uk,
linux-i2c@...r.kernel.org, linux-gpio@...r.kernel.org,
mengyuanlou@...-swift.com
Subject: Re: [RFC PATCH net-next v5 1/9] net: txgbe: Add software nodes to
support phylink
On Wed, Apr 26, 2023 at 03:14:26PM +0800, Jiawen Wu wrote:
...
> @@ -663,10 +665,21 @@ static int txgbe_probe(struct pci_dev *pdev,
> "0x%08x", etrack_id);
> }
>
> - err = register_netdev(netdev);
> + txgbe = devm_kzalloc(&pdev->dev, sizeof(*txgbe), GFP_KERNEL);
> + if (!txgbe)
Hi Jiawen,
I think yo need to set err here.
> + goto err_release_hw;
> +
...
Powered by blists - more mailing lists