netdev - Re: [net-next v3 02/15] idpf: add module register and probe functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9110854d-7bdc-db02-068e-3cc75800092d@intel.com>
Date:   Fri, 28 Apr 2023 16:05:34 -0700
From:   "Tantilov, Emil S" <emil.s.tantilov@...el.com>
To:     Shannon Nelson <shannon.nelson@....com>,
        <intel-wired-lan@...ts.osuosl.org>
CC:     <netdev@...r.kernel.org>, <joshua.a.hay@...el.com>,
        <sridhar.samudrala@...el.com>, <jesse.brandeburg@...el.com>,
        <anthony.l.nguyen@...el.com>, <willemb@...gle.com>,
        <decot@...gle.com>, <pabeni@...hat.com>, <kuba@...nel.org>,
        <edumazet@...gle.com>, <davem@...emloft.net>,
        <alan.brady@...el.com>, <madhu.chittim@...el.com>,
        <phani.r.burra@...el.com>, <shailendra.bhatnagar@...el.com>,
        <pavan.kumar.linga@...el.com>, <simon.horman@...igine.com>,
        <leon@...nel.org>
Subject: Re: [net-next v3 02/15] idpf: add module register and probe
 functionality



On 4/27/2023 4:24 PM, Shannon Nelson wrote:
> On 4/26/23 7:09 PM, Emil Tantilov wrote:
>>
>> From: Phani Burra <phani.r.burra@...el.com>
>>
> 
> [...]
> 
>> +static int idpf_probe(struct pci_dev *pdev, const struct 
>> pci_device_id *ent)
>> +{
>> +       struct device *dev = &pdev->dev;
>> +       struct idpf_adapter *adapter;
>> +       int err;
>> +
>> +       adapter = kzalloc(sizeof(*adapter), GFP_KERNEL);
>> +       if (!adapter)
>> +               return -ENOMEM;
>> +       adapter->pdev = pdev;
> 
> The custom more recently has been to allocate the devlink struct early 
> on and build the device struct from that allocation.  You likely will 
> want to follow along and play in the devlink world.
> 
> sln
> 

Good point, we'll keep that in mind for future development.

Thanks,
Emil