netdev - Re: [PATCH net] wifi: mac80211: Fix puncturing bitmap handling in __ieee80211_csa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a94ce60d-423a-5f8e-5f8e-9b462854db54@wanadoo.fr>
Date:   Fri, 28 Apr 2023 10:19:56 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Kalle Valo <kvalo@...nel.org>
Cc:     christophe.jaillet@...adoo.fr, davem@...emloft.net,
        edumazet@...gle.com, johannes.berg@...el.com,
        johannes@...solutions.net, kernel-janitors@...r.kernel.org,
        kuba@...nel.org, linux-kernel@...r.kernel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        pabeni@...hat.com, quic_alokad@...cinc.com,
        quic_msinada@...cinc.com
Subject: Re: [PATCH net] wifi: mac80211: Fix puncturing bitmap handling in
 __ieee80211_csa_finalize()

Le 28/04/2023 à 07:04, Kalle Valo a écrit :
> Christophe JAILLET <christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@...lic.gmane.org> writes:
> 
>> 'changed' can be OR'ed with BSS_CHANGED_EHT_PUNCTURING which is larger than
>> an u32.
>> So, turn 'changed' into an u64 and update ieee80211_set_after_csa_beacon()
>> accordingly.
>>
>> In the commit in Fixes, only ieee80211_start_ap() was updated.
>>
>> Fixes: 2cc25e4b2a04 ("wifi: mac80211: configure puncturing bitmap")
>> Signed-off-by: Christophe JAILLET <christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@...lic.gmane.org>
> 
> FWIW mac80211 patches go to wireless tree, not net.
> 

Hi,

net/<something> or drivers/net/<something> goes to 'net'.
drivers/net/wireless/<something> goes to 'wireless'.

now:
net/mac80211/ goes also to 'wireless' as well.
ath11 and ath12 are special cases that goes to 'ath'.

Based on the get_maintainer.pl, my last patch against drivers/isdn looks 
well suited to deserve a -net-next as well?

without speaking of -next variations.

How many other oddities are there?

I try to make my best to add net or net-next.
I could do the same with wireless. (I guess that there is also a 
wireless-next?)

I can do it when rules are SIMPLE.

Is there a place where ALL these "rules" are described?
Could MAINTAINERS and scripts be instrumented for that?

I DO understand that the easiest it is for maintainers, the better for 
them, but please stop asking for casual contributors to know that and 
follow your, not that easy to find or remember, rules.

I'm tempt not to TRY to put the right branch in the subject of my 
commits anymore, because even when I try to do it right and follow 
simple rules for that, it is not enough and I'm WRONG.

Most of my contributions are related to error handling paths.
The remaining ones are mostly related to number of LoC reduction.

Should my contributions be ignored because of the lack of tools to help 
me target the correct branch, then keep the bugs and keep the LoC.

git log --oneline --author=jaillet --grep Fixes: drivers/net | wc -l
97
git log --oneline --author=jaillet drivers/net | wc -l
341

git log --oneline --author=jaillet --grep Fixes: net | wc -l
7
git log --oneline --author=jaillet net | wc -l
327

No hard feelings, but slightly upset.

:/

CJ