netdev - Re: [EXTERNAL] Re: [RFC PATCH v6 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Apr 2023 15:47:52 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Md Danish Anwar <a0501179@...com>
Cc:     MD Danish Anwar <danishanwar@...com>,
        "Andrew F. Davis" <afd@...com>, Tero Kristo <kristo@...nel.org>,
        Suman Anna <s-anna@...com>, Roger Quadros <rogerq@...nel.org>,
        YueHaibing <yuehaibing@...wei.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>, andrew@...n.ch,
        Randy Dunlap <rdunlap@...radead.org>,
        Richard Cochran <richardcochran@...il.com>, nm@...com,
        ssantosh@...nel.org, srk@...com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [EXTERNAL] Re: [RFC PATCH v6 2/2] net: ti: icssg-prueth: Add
 ICSSG ethernet driver

On Fri, Apr 28, 2023 at 02:36:42PM +0530, Md Danish Anwar wrote:
> Hi Simon.
> 
> On 27/04/23 12:42, Md Danish Anwar wrote:
> > Hi Simon,
> > Thanks for the comments.
> > 
> > On 27/04/23 00:39, Simon Horman wrote:
> >> On Mon, Apr 24, 2023 at 11:02:33AM +0530, MD Danish Anwar wrote:
> >>> From: Roger Quadros <rogerq@...com>
> >>>
> >>> This is the Ethernet driver for TI AM654 Silicon rev. 2
> >>> with the ICSSG PRU Sub-system running dual-EMAC firmware.
> >>>
> 
> [ ... ]
> 
> >>
> >> ...
> >>
> >>> +MODULE_AUTHOR("Roger Quadros <rogerq@...com>");
> >>> +MODULE_AUTHOR("Puranjay Mohan <p-mohan@...com>");
> >>> +MODULE_AUTHOR("Md Danish Anwar <danishanwar@...com>");
> >>> +MODULE_DESCRIPTION("PRUSS ICSSG Ethernet Driver");
> >>> +MODULE_LICENSE("GPL");
> >>
> >> SPDK says GPL-2.0, so perhaps this should be "GPL v2" ?
> >>
> 
> I am getting checkpatch warning while changing GPL version.
> 
> WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure
> the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity")
> #3602: FILE: drivers/net/ethernet/ti/icssg_prueth.c:1866:
> +MODULE_LICENSE("GPL v2");
> 
> Should I ignore this warning and change it to "GPL v2"

I guess that "GPL" is correct after all.
Sorry for the noise.