netdev - Re: [PATCH v2 iproute2-next 09/10] tc/mqprio: add support for preemptible traffic classes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230430013314.saansheqqfn2j7wl@skbuf>
Date:   Sun, 30 Apr 2023 04:33:14 +0300
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH v2 iproute2-next 09/10] tc/mqprio: add support for
 preemptible traffic classes

On Sat, Apr 29, 2023 at 05:42:55PM -0700, Stephen Hemminger wrote:
> On Tue, 18 Apr 2023 14:39:52 +0300
> Vladimir Oltean <vladimir.oltean@....com> wrote:
> 
> > +	tc = rta_getattr_u32(tb[TCA_MQPRIO_TC_ENTRY_INDEX]);
> > +	/* Prevent array out of bounds access */
> > +	if (tc >= TC_QOPT_MAX_QUEUE) {
> > +		fprintf(stderr, "Unexpected tc entry index %d\n", tc);
> > +		return;
> > +	}
> 
> This creates a ABI dependency, what if kernel config changes?
>

If TC_QOPT_MAX_QUEUE changes its value, struct tc_mqprio_qopt changes
its binary layout in an incompatible way.