netdev - [PATCH ethtool 1/3] Update FAM syntax to conform to std C.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 30 Apr 2023 18:50:50 -0400
From:   Nicholas Vinson <nvinson234@...il.com>
To:     mkubecek@...e.cz
Cc:     Nicholas Vinson <nvinson234@...il.com>, netdev@...r.kernel.org
Subject: [PATCH ethtool 1/3] Update FAM syntax to conform to std C.

Found via gcc -fanalyzer. When using the non-standard FAM syntax:

    uint32_t req_mask[0];

gcc-13 with the -fanalyzer flag generates an internal compiler error.
Updating the syntax to use the standard C syntax:

    uint32_t req_mask[];

works around the gcc bug.

Signed-off-by: Nicholas Vinson <nvinson234@...il.com>
---
 netlink/features.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netlink/features.c b/netlink/features.c
index a4dae8f..a93f3e7 100644
--- a/netlink/features.c
+++ b/netlink/features.c
@@ -266,7 +266,7 @@ int nl_gfeatures(struct cmd_context *ctx)

 struct sfeatures_context {
 	bool			nothing_changed;
-	uint32_t		req_mask[0];
+	uint32_t		req_mask[];
 };

 static int find_feature(const char *name,
-- 
2.40.1