netdev - Re: [PATCH net v1 2/2] virtio_net: Close queue pairs using helper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9dba94bb-3e40-6809-3f5a-cbb0ae19c5b7@nvidia.com>
Date:   Mon, 1 May 2023 09:58:18 -0400
From:   Feng Liu <feliu@...dia.com>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
        Jason Wang <jasowang@...hat.com>,
        "Michael S . Tsirkin" <mst@...hat.com>,
        Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        William Tu <witu@...dia.com>, Parav Pandit <parav@...dia.com>
Subject: Re: [PATCH net v1 2/2] virtio_net: Close queue pairs using helper
 function



On 2023-05-01 a.m.8:44, Simon Horman wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Fri, Apr 28, 2023 at 06:43:46PM -0400, Feng Liu wrote:
>> Use newly introduced helper function that exactly does the same of
>> closing the queue pairs.
>>
>> Signed-off-by: Feng Liu <feliu@...dia.com>
>> Reviewed-by: William Tu <witu@...dia.com>
>> Reviewed-by: Parav Pandit <parav@...dia.com>
> 
> I guess this was put in a separate patch to 1/2, as it's more
> net-next material, as opposed to 1/2 which seems to be net material.
> FWIIW, I'd lean to putting 1/2 in net. And holding this one for net-next.
> 
> That aside, this looks good to me.
> 
> Reviewed-by: Simon Horman <simon.horman@...igine.com>

Will do, thanks Simon