lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <b31f3a6a-e6ab-71a3-fb78-d01f2fe00464@ti.com> Date: Tue, 2 May 2023 13:09:01 -0500 From: Judith Mendez <jm@...com> To: Marc Kleine-Budde <mkl@...gutronix.de> CC: Chandrasekar Ramakrishnan <rcsekar@...sung.com>, Wolfgang Grandegger <wg@...ndegger.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, <linux-can@...r.kernel.org>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Schuyler Patton <spatton@...com>, Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>, Rob Herring <robh+dt@...nel.org>, <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>, Oliver Hartkopp <socketcan@...tkopp.net>, Simon Horman <simon.horman@...igine.com> Subject: Re: [PATCH v4 2/4] can: m_can: Add hrtimer to generate software interrupt Hello Marc On 5/2/23 01:37, Marc Kleine-Budde wrote: > On 01.05.2023 17:46:22, Judith Mendez wrote: >> Add an hrtimer to MCAN class device. Each MCAN will have its own >> hrtimer instantiated if there is no hardware interrupt found and >> poll-interval property is defined in device tree M_CAN node. >> >> The hrtimer will generate a software interrupt every 1 ms. In >> hrtimer callback, we check if there is a transaction pending by >> reading a register, then process by calling the isr if there is. >> >> Signed-off-by: Judith Mendez <jm@...com> > > I think this patch is as good as it gets, given the HW and SW > limitations of the coprocessor. > > Some minor nitpicks inline. No need to resend from my point of view, > I'll fixup while applying the patch. Thanks Marc, really appreciate your feedback and attention. Same to everyone who helped make these patches better. (: regards, Judith
Powered by blists - more mailing lists