lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <c9765637-4601-0a7d-7e5e-4c3e9d52d90f@arinc9.com> Date: Tue, 2 May 2023 23:05:41 +0300 From: Arınç ÜNAL <arinc.unal@...nc9.com> To: Florian Fainelli <f.fainelli@...il.com>, Sean Wang <sean.wang@...iatek.com>, Landen Chao <Landen.Chao@...iatek.com>, DENG Qingfang <dqfext@...il.com>, Daniel Golle <daniel@...rotopia.org>, Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Matthias Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, René van Dorst <opensource@...rst.com> Cc: Richard van Schagen <richard@...terhints.com>, Richard van Schagen <vschagen@...com>, Frank Wunderlich <frank-w@...lic-files.de>, Bartel Eerdekens <bartel.eerdekens@...stell8.be>, mithat.guner@...ont.com, erkin.bozoglu@...ont.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org Subject: Re: [PATCH net 2/2] net: dsa: mt7530: fix network connectivity with multiple CPU ports On 02/05/2023 21:30, Florian Fainelli wrote: > > > On 5/1/2023 5:15 AM, arinc9.unal@...il.com wrote: >> From: Arınç ÜNAL <arinc.unal@...nc9.com> >> >> On mt753x_cpu_port_enable() there's code that enables flooding for the >> CPU >> port only. Since mt753x_cpu_port_enable() runs twice when both CPU ports >> are enabled, port 6 becomes the only port to forward the frames to. But >> port 5 is the active port, so no frames received from the user ports will >> be forwarded to port 5 which breaks network connectivity. >> >> Every bit of the BC_FFP, UNM_FFP, and UNU_FFP bits represents a port. Fix >> this issue by setting the bit that corresponds to the CPU port without >> overwriting the other bits. >> >> Clear the bits beforehand only for the MT7531 switch. According to the >> documents MT7621 Giga Switch Programming Guide v0.3 and MT7531 Reference >> Manual for Development Board v1.0, after reset, the BC_FFP, UNM_FFP, and >> UNU_FFP bits are set to 1 for MT7531, 0 for MT7530. >> >> Tested-by: Arınç ÜNAL <arinc.unal@...nc9.com> > > This tag is implied by your Signed-off-by tag. No Fixes tag for this one? I've put it with v2. Let me send v3 to remove the tested-by and add your reviewed-by to the other patch. Arınç
Powered by blists - more mailing lists