lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZFEiOdK0/UxKiPQQ@corigine.com> Date: Tue, 2 May 2023 16:46:17 +0200 From: Simon Horman <simon.horman@...igine.com> To: Dominique Martinet <asmadeus@...ewreck.org> Cc: Eric Van Hensbergen <ericvh@...il.com>, Latchesar Ionkov <lucho@...kov.net>, Christian Schoenebeck <linux_oss@...debyte.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, v9fs@...ts.linux.dev, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 1/5] 9p: fix ignored return value in v9fs_dir_release On Thu, Apr 27, 2023 at 08:23:34PM +0900, Dominique Martinet wrote: > retval from filemap_fdatawrite was immediately overwritten by the > following p9_fid_put: preserve any error in fdatawrite if there > was any first. > > This fixes the following scan-build warning: > fs/9p/vfs_dir.c:220:4: warning: Value stored to 'retval' is never read [deadcode.DeadStores] > retval = filemap_fdatawrite(inode->i_mapping); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Perhaps: Fixes: 89c58cb395ec ("fs/9p: fix error reporting in v9fs_dir_release") > Signed-off-by: Dominique Martinet <asmadeus@...ewreck.org> Reviewed-by: Simon Horman <simon.horman@...igine.com>
Powered by blists - more mailing lists