lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230503133752.4176720-1-Ilia.Gavrilov@infotecs.ru> Date: Wed, 3 May 2023 13:37:59 +0000 From: Gavrilov Ilia <Ilia.Gavrilov@...otecs.ru> To: Marcelo Ricardo Leitner <marcelo.leitner@...il.com> CC: Simon Horman <simon.horman@...igine.com>, Neil Horman <nhorman@...driver.com>, Xin Long <lucien.xin@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "linux-sctp@...r.kernel.org" <linux-sctp@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "lvc-project@...uxtesting.org" <lvc-project@...uxtesting.org> Subject: [PATCH net v4] sctp: fix a potential OOB access in sctp_sched_set_sched() The 'sched' index value must be checked before accessing an element of the 'sctp_sched_ops' array. Otherwise, it can lead to OOB access. Note that it's harmless since the 'sched' parameter is checked before calling 'sctp_sched_set_sched'. Found by InfoTeCS on behalf of Linux Verification Center (linuxtesting.org) with SVACE. Reviewed-by: Xin Long <lucien.xin@...il.com> Reviewed-by: Simon Horman <simon.horman@...igine.com> Signed-off-by: Ilia.Gavrilov <Ilia.Gavrilov@...otecs.ru> --- V2: - Change the order of local variables - Specify the target tree in the subject V3: - Change description - Remove 'fixes' V4: - revert to V2 net/sctp/stream_sched.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/net/sctp/stream_sched.c b/net/sctp/stream_sched.c index 330067002deb..4d076a9b8592 100644 --- a/net/sctp/stream_sched.c +++ b/net/sctp/stream_sched.c @@ -146,18 +146,19 @@ static void sctp_sched_free_sched(struct sctp_stream *stream) int sctp_sched_set_sched(struct sctp_association *asoc, enum sctp_sched_type sched) { - struct sctp_sched_ops *n = sctp_sched_ops[sched]; struct sctp_sched_ops *old = asoc->outqueue.sched; struct sctp_datamsg *msg = NULL; + struct sctp_sched_ops *n; struct sctp_chunk *ch; int i, ret = 0; - if (old == n) - return ret; - if (sched > SCTP_SS_MAX) return -EINVAL; + n = sctp_sched_ops[sched]; + if (old == n) + return ret; + if (old) sctp_sched_free_sched(&asoc->stream); -- 2.30.2
Powered by blists - more mailing lists