Message-ID: <052b66e9-eed2-15a4-cecf-fa26f5cc49c9@redhat.com>
Date: Wed, 3 May 2023 16:33:01 +0200
From: David Hildenbrand <david@...hat.com>
To: Lorenzo Stoakes <lstoakes@...il.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>
Cc: Jason Gunthorpe <jgg@...pe.ca>, Jens Axboe <axboe@...nel.dk>,
 Matthew Wilcox <willy@...radead.org>,
 Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
 Leon Romanovsky <leon@...nel.org>, Christian Benvenuti <benve@...co.com>,
 Nelson Escobar <neescoba@...co.com>, Bernard Metzler <bmt@...ich.ibm.com>,
 Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
 Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>,
 Bjorn Topel <bjorn@...nel.org>, Magnus Karlsson <magnus.karlsson@...el.com>,
 Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 Jonathan Lemon <jonathan.lemon@...il.com>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Christian Brauner <brauner@...nel.org>,
 Richard Cochran <richardcochran@...il.com>,
 Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>, linux-fsdevel@...r.kernel.org,
 linux-perf-users@...r.kernel.org, netdev@...r.kernel.org,
 bpf@...r.kernel.org, Oleg Nesterov <oleg@...hat.com>,
 Jason Gunthorpe <jgg@...dia.com>, John Hubbard <jhubbard@...dia.com>,
 Jan Kara <jack@...e.cz>, "Kirill A . Shutemov" <kirill@...temov.name>,
 Pavel Begunkov <asml.silence@...il.com>, Mika Penttila
 <mpenttil@...hat.com>, Dave Chinner <david@...morbit.com>,
 Theodore Ts'o <tytso@....edu>, Peter Xu <peterx@...hat.com>,
 Matthew Rosato <mjrosato@...ux.ibm.com>,
 "Paul E . McKenney" <paulmck@...nel.org>,
 Christian Borntraeger <borntraeger@...ux.ibm.com>
Subject: Re: [PATCH v8 2/3] mm/gup: disallow FOLL_LONGTERM GUP-nonfast writing
 to file-backed mappings

On 03.05.23 00:51, Lorenzo Stoakes wrote:
> Writing to file-backed mappings which require folio dirty tracking using
> GUP is a fundamentally broken operation, as kernel write access to GUP
> mappings do not adhere to the semantics expected by a file system.
> 
> A GUP caller uses the direct mapping to access the folio, which does not
> cause write notify to trigger, nor does it enforce that the caller marks
> the folio dirty.
> 
> The problem arises when, after an initial write to the folio, writeback
> results in the folio being cleaned and then the caller, via the GUP
> interface, writes to the folio again.
> 
> As a result of the use of this secondary, direct, mapping to the folio no
> write notify will occur, and if the caller does mark the folio dirty, this
> will be done so unexpectedly.
> 
> For example, consider the following scenario:-
> 
> 1. A folio is written to via GUP which write-faults the memory, notifying
>     the file system and dirtying the folio.
> 2. Later, writeback is triggered, resulting in the folio being cleaned and
>     the PTE being marked read-only.
> 3. The GUP caller writes to the folio, as it is mapped read/write via the
>     direct mapping.
> 4. The GUP caller, now done with the page, unpins it and sets it dirty
>     (though it does not have to).
> 
> This results in both data being written to a folio without writenotify, and
> the folio being dirtied unexpectedly (if the caller decides to do so).
> 
> This issue was first reported by Jan Kara [1] in 2018, where the problem
> resulted in file system crashes.
> 
> This is only relevant when the mappings are file-backed and the underlying
> file system requires folio dirty tracking. File systems which do not, such
> as shmem or hugetlb, are not at risk and therefore can be written to
> without issue.
> 
> Unfortunately this limitation of GUP has been present for some time and
> requires future rework of the GUP API in order to provide correct write
> access to such mappings.
> 
> However, for the time being we introduce this check to prevent the most
> egregious case of this occurring, use of the FOLL_LONGTERM pin.
> 
> These mappings are considerably more likely to be written to after
> folios are cleaned and thus simply must not be permitted to do so.
> 
> This patch changes only the slow-path GUP functions, a following patch
> adapts the GUP-fast path along similar lines.
> 
> [1]:https://lore.kernel.org/linux-mm/20180103100430.GE4911@quack2.suse.cz/
> 
> Suggested-by: Jason Gunthorpe <jgg@...dia.com>
> Signed-off-by: Lorenzo Stoakes <lstoakes@...il.com>
> Reviewed-by: John Hubbard <jhubbard@...dia.com>
> Reviewed-by: Mika Penttilä <mpenttil@...hat.com>
> Reviewed-by: Jan Kara <jack@...e.cz>
> Reviewed-by: Jason Gunthorpe <jgg@...dia.com>
> ---

Acked-by: David Hildenbrand <david@...hat.com>


-- 
Thanks,

David / dhildenb

Powered by blists - more mailing lists