lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZFIWnDjVQ1YrHBRg@nanopsycho> Date: Wed, 3 May 2023 10:09:00 +0200 From: Jiri Pirko <jiri@...nulli.us> To: Vadim Fedorenko <vadfed@...a.com> Cc: Jakub Kicinski <kuba@...nel.org>, Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>, Jonathan Lemon <jonathan.lemon@...il.com>, Paolo Abeni <pabeni@...hat.com>, Milena Olech <milena.olech@...el.com>, Michal Michalik <michal.michalik@...el.com>, linux-arm-kernel@...ts.infradead.org, Vadim Fedorenko <vadim.fedorenko@...ux.dev>, poros@...hat.com, mschmidt@...hat.com, netdev@...r.kernel.org, linux-clk@...r.kernel.org Subject: Re: [RFC PATCH v7 2/8] dpll: Add DPLL framework base functions Fri, Apr 28, 2023 at 02:20:03AM CEST, vadfed@...a.com wrote: >From: Vadim Fedorenko <vadim.fedorenko@...ux.dev> [...] >+static struct dpll_pin * >+dpll_pin_alloc(u64 clock_id, u8 pin_idx, struct module *module, >+ const struct dpll_pin_properties *prop) >+{ >+ struct dpll_pin *pin; >+ int ret, fs_size; >+ >+ pin = kzalloc(sizeof(*pin), GFP_KERNEL); >+ if (!pin) >+ return ERR_PTR(-ENOMEM); >+ pin->pin_idx = pin_idx; >+ pin->clock_id = clock_id; >+ pin->module = module; >+ refcount_set(&pin->refcount, 1); >+ if (WARN_ON(!prop->label)) { Why exactly label has to be mandatory? In mlx5, I have no use for it. Please make it optional. IIRC, I asked for this in the last review as well. >+ ret = -EINVAL; >+ goto err; >+ } >+ pin->prop.label = kstrdup(prop->label, GFP_KERNEL); Labels should be static const string. Do you see a usecase when you need to dup it? If not, remove this please. >+ if (!pin->prop.label) { >+ ret = -ENOMEM; >+ goto err; >+ } [...]
Powered by blists - more mailing lists