netdev - Re: [PATCH net] ethtool: Fix uninitialized number of lanes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 03 May 2023 08:20:21 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Ido Schimmel <idosch@...dia.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
 pabeni@...hat.com, edumazet@...gle.com, danieller@...dia.com,
 mlxsw@...dia.com
Subject: Re: [PATCH net] ethtool: Fix uninitialized number of lanes

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@...emloft.net>:

On Tue,  2 May 2023 15:20:50 +0300 you wrote:
> It is not possible to set the number of lanes when setting link modes
> using the legacy IOCTL ethtool interface. Since 'struct
> ethtool_link_ksettings' is not initialized in this path, drivers receive
> an uninitialized number of lanes in 'struct
> ethtool_link_ksettings::lanes'.
> 
> When this information is later queried from drivers, it results in the
> ethtool code making decisions based on uninitialized memory, leading to
> the following KMSAN splat [1]. In practice, this most likely only
> happens with the tun driver that simply returns whatever it got in the
> set operation.
> 
> [...]

Here is the summary with links:
  - [net] ethtool: Fix uninitialized number of lanes
    https://git.kernel.org/netdev/net/c/9ad685dbfe7e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html