lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87bkj13fsa.fsf@cloudflare.com> Date: Wed, 03 May 2023 11:49:57 +0200 From: Jakub Sitnicki <jakub@...udflare.com> To: John Fastabend <john.fastabend@...il.com> Cc: daniel@...earbox.net, lmb@...valent.com, edumazet@...gle.com, bpf@...r.kernel.org, netdev@...r.kernel.org, ast@...nel.org, andrii@...nel.org, will@...valent.com Subject: Re: [PATCH bpf v7 03/13] bpf: sockmap, reschedule is now done through backlog On Tue, May 02, 2023 at 08:51 AM -07, John Fastabend wrote: > Now that the backlog manages the reschedule() logic correctly we can drop > the partial fix to reschedule from recvmsg hook. > > Rescheduling on recvmsg hook was added to address a corner case where we > still had data in the backlog state but had nothing to kick it and > reschedule the backlog worker to run and finish copying data out of the > state. This had a couple limitations, first it required user space to > kick it introducing an unnecessary EBUSY and retry. Second it only > handled the ingress case and egress redirects would still be hung. > > With the correct fix, pushing the reschedule logic down to where the > enomem error occurs we can drop this fix. > > Fixes: bec217197b412 ("skmsg: Schedule psock work if the cached skb exists on the psock") > Signed-off-by: John Fastabend <john.fastabend@...il.com> > --- Reviewed-by: Jakub Sitnicki <jakub@...udflare.com>
Powered by blists - more mailing lists