netdev - Re: [PATCH RFC net-next 0/2] pds_core: add switchdev and tc for vlan offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ccfccde0-9753-1e54-75b0-f6f1d683d765@amd.com>
Date: Wed, 3 May 2023 15:49:27 -0700
From: Shannon Nelson <shannon.nelson@....com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: brett.creeley@....com, netdev@...r.kernel.org, drivers@...sando.io
Subject: Re: [PATCH RFC net-next 0/2] pds_core: add switchdev and tc for vlan
 offload

On 5/2/23 4:43 PM, Jakub Kicinski wrote:
> 
> On Thu, 27 Apr 2023 09:45:44 -0700 Shannon Nelson wrote:
>> This is an RFC for adding to the pds_core driver some very simple support
>> for VF representors and a tc command for offloading VF port vlans.
>>
>> The problem to solve is how to request that a NIC do the push/pop of port
>> vlans on a VF.  The initial pds_core patchset[0] included this support
>> through the legacy ip-link methods with a PF netdev that had no datapath,
>> simply existing to enable commands such as
>>      ip link set <pf> vf <vfid> vlan <vid>
>> This was soundly squashed with a request to create proper VF representors.
>> The pds_core driver has since been reworked and merged without this feature.
> 
> Have you read the representors documentation? Passing traffic is
> crucial.

Given that there is no traffic to the host PF in this case, and I can't 
do anything more than wave my hands at vague promises for the future, 
perhaps tc and representors is the wrong path for now.

But there remains a need for some port related configuration.  I can 
take a stab at adding this concept to "devlink port function" and see 
what discussion follows from there.

sln