netdev - Re: [PATCH iproute2-next] rdma: Report device protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230504074842.GR525452@unreal>
Date: Thu, 4 May 2023 10:48:42 +0300
From: Leon Romanovsky <leonro@...dia.com>
To: Kamal Heib <kheib@...hat.com>
CC: Stephen Hemminger <stephen@...workplumber.org>, <netdev@...r.kernel.org>,
	<linux-rdma@...r.kernel.org>
Subject: Re: [PATCH iproute2-next] rdma: Report device protocol

On Wed, May 03, 2023 at 05:03:42PM -0400, Kamal Heib wrote:
> Add support for reporting the device protocol.
> 
> $ rdma dev
> 11: mlx5_0: node_type ca proto roce fw 12.28.2006
>     node_guid 248a:0703:004b:f094 sys_image_guid 248a:0703:004b:f094
> 12: mlx5_1: node_type ca proto ib fw 12.28.2006
>     node_guid 248a:0703:0049:d4f0 sys_image_guid 248a:0703:0049:d4f0
> 13: mlx5_2: node_type ca proto ib fw 12.28.2006
>     node_guid 248a:0703:0049:d4f1 sys_image_guid 248a:0703:0049:d4f0
> 17: siw0: node_type rnic proto iw node_guid
>     0200:00ff:fe00:0000 sys_image_guid 0200:00ff:fe00:0000
> 
> Signed-off-by: Kamal Heib <kheib@...hat.com>
> ---
>  rdma/dev.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/rdma/dev.c b/rdma/dev.c
> index c684dde4a56f..04c2a574405c 100644
> --- a/rdma/dev.c
> +++ b/rdma/dev.c
> @@ -189,6 +189,16 @@ static void dev_print_node_type(struct rd *rd, struct nlattr **tb)
>  			   node_str);
>  }
>  
> +static void dev_print_dev_proto(struct rd *rd, struct nlattr **tb)
> +{
> +       const char *str;
> +       if (!tb[RDMA_NLDEV_ATTR_DEV_PROTOCOL])
> +               return;
> +
> +       str = mnl_attr_get_str(tb[RDMA_NLDEV_ATTR_DEV_PROTOCOL]);
> +       print_color_string(PRINT_ANY, COLOR_NONE, "proto", "proto %s ", str);

Please, let's use full word "protocol" and not "proto".

Other than that,
Acked-by: Leon Romanovsky <leonro@...dia.com>