netdev - Re: [PATCH v2] net: ipconfig: Allow DNS to be overwritten by DHCPACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230504094424.0458973d@kernel.org>
Date: Thu, 4 May 2023 09:44:24 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Martin Wetterwald <martin@...terwald.eu>
Cc: davem@...emloft.net, dsahern@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: ipconfig: Allow DNS to be overwritten by
 DHCPACK

On Thu, 4 May 2023 10:00:04 +0200 Martin Wetterwald wrote:
> +#ifdef IPCONFIG_DHCP
> +            if (ic_nameservers[i] == NONE ||
> +                ic_nameservers_fallback)
> +#else
>              if (ic_nameservers[i] == NONE)
> +#endif

FWIW I'd vote to move the variable out of the #ifdef and avoid the hairy
code, it's just 4 bytes.