[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 5 May 2023 18:43:47 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Tobias Brunner <tobias@...ongswan.org>
Cc: Steffen Klassert <steffen.klassert@...unet.com>, netdev@...r.kernel.org,
"David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH ipsec] xfrm: Reject optional tunnel/BEET mode templates
in outbound policies
On Fri, May 05, 2023 at 12:16:16PM +0200, Tobias Brunner wrote:
> xfrm_state_find() uses `encap_family` of the current template with
> the passed local and remote addresses to find a matching state.
> If an optional tunnel or BEET mode template is skipped in a mixed-family
> scenario, there could be a mismatch causing an out-of-bounds read as
> the addresses were not replaced to match the family of the next template.
>
> While there are theoretical use cases for optional templates in outbound
> policies, the only practical one is to skip IPComp states in inbound
> policies if uncompressed packets are received that are handled by an
> implicitly created IPIP state instead.
>
> Signed-off-by: Tobias Brunner <tobias@...ongswan.org>
> ---
> net/xfrm/xfrm_user.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
However, I think a similar check needs to be added to af_key.c
as it too seems to allow optional outbound tunnel-mode templates.
Thanks,
--
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists