[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<168333397774.7813.3273700580854407784.stgit@oracle-102.nfsv4bat.org>
Date: Fri, 05 May 2023 20:46:27 -0400
From: Chuck Lever <cel@...nel.org>
To: kernel-tls-handshake@...ts.linux.dev
Cc: netdev@...r.kernel.org, dan.carpenter@...aro.org
Subject: [PATCH v2 3/6] net/handshake: Fix uninitialized local variable
From: Chuck Lever <chuck.lever@...cle.com>
trace_handshake_cmd_done_err() simply records the pointer in @req,
so initializing it to NULL is sufficient and safe.
Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
Fixes: 3b3009ea8abb ("net/handshake: Create a NETLINK service for handling handshake requests")
Reviewed-by: Simon Horman <simon.horman@...igine.com>
Signed-off-by: Chuck Lever <chuck.lever@...cle.com>
---
net/handshake/netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/handshake/netlink.c b/net/handshake/netlink.c
index 032d96152e2f..11cc275d726a 100644
--- a/net/handshake/netlink.c
+++ b/net/handshake/netlink.c
@@ -154,8 +154,8 @@ int handshake_nl_accept_doit(struct sk_buff *skb, struct genl_info *info)
int handshake_nl_done_doit(struct sk_buff *skb, struct genl_info *info)
{
struct net *net = sock_net(skb->sk);
+ struct handshake_req *req = NULL;
struct socket *sock = NULL;
- struct handshake_req *req;
int fd, status, err;
if (GENL_REQ_ATTR_CHECK(info, HANDSHAKE_A_DONE_SOCKFD))
Powered by blists - more mailing lists