lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <000001d97ffd$39ae2db0$ad0a8910$@trustnetic.com> Date: Sat, 6 May 2023 17:29:15 +0800 From: Jiawen Wu <jiawenwu@...stnetic.com> To: <andy.shevchenko@...il.com> Cc: <netdev@...r.kernel.org>, <jarkko.nikula@...ux.intel.com>, <andriy.shevchenko@...ux.intel.com>, <mika.westerberg@...ux.intel.com>, <jsd@...ihalf.com>, <Jose.Abreu@...opsys.com>, <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>, <linux-i2c@...r.kernel.org>, <linux-gpio@...r.kernel.org>, <mengyuanlou@...-swift.com> Subject: RE: [RFC PATCH net-next v6 2/9] i2c: designware: Add driver support for Wangxun 10Gb NIC On Saturday, May 6, 2023 4:11 AM, andy.shevchenko@...il.com wrote: > Fri, May 05, 2023 at 09:48:01PM +0300, andy.shevchenko@...il.com kirjoitti: > > Fri, May 05, 2023 at 03:42:21PM +0800, Jiawen Wu kirjoitti: > > ... > > > > + device_property_read_u32(&pdev->dev, "wx,i2c-snps-model", &dev->flags); > > > > I believe in your case it should be named something like > > "linux,i2c-synopsys-platform". But in any case this I leave > > to the more experienced people. > > Or "snps,i2c-platform", I dunno... I thought you wanted me to introduce a property specific to my device, so I named it "wx,...". But if it's a universal property for platform device, maybe it's necessary to check if flag is NULL, otherwise the second result will overwrite it.
Powered by blists - more mailing lists