netdev - Re: [PATCH] net:ethernet:freescale:dpaa2:Remove unnecessary (void*) conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 6 May 2023 13:06:22 +0200
From: Simon Horman <simon.horman@...igine.com>
To: wuych <yunchuan@...china.com>
Cc: ioana.ciornei@....com, davem@...emloft.net, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net:ethernet:freescale:dpaa2:Remove unnecessary (void*)
 conversions

On Sat, May 06, 2023 at 05:44:28PM +0800, wuych wrote:
> Pointer variables of void * type do not require type cast.
> 
> Signed-off-by: wuych <yunchuan@...china.com>

Hi,

this looks good, but a few things to improve:

* Did you miss the instance in  dpaa2_dbg_bp_show()
* For networking patches, please set the target tree in the subject.
  As this is not a fix it should be 'net-next' (if it was a fix it would be
  'net')
  [PATCH net-next v2] ...
* As per the form letter below, -net-next is currently closed,
  so please repost after May 8th.
* I think the subject prefix should be dpaa2-eth:
  [PATCH net-next v2] dpaa2: ...
* I think the patch subject could be a bit clearer
  [PATCH net-next v2] dpaa2: Remove unnecessary cast of void pointers

Lastly, some text borrowed from others:

## Form letter - net-next-closed

The merge window for v6.3 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after May 8th.

RFC patches sent for review only are obviously welcome at any time.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle