lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <202305070938.QRjcW4tq-lkp@intel.com> Date: Sun, 7 May 2023 09:29:51 +0800 From: kernel test robot <lkp@...el.com> To: Chris Leech <cleech@...hat.com>, Lee Duncan <lduncan@...e.com>, linux-scsi@...r.kernel.org, open-iscsi@...glegroups.com, netdev@...r.kernel.org Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, Chris Leech <cleech@...hat.com> Subject: Re: [PATCH 06/11] iscsi: set netns for tcp and iser hosts Hi Chris, kernel test robot noticed the following build warnings: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on jejb-scsi/for-next horms-ipvs/master linus/master v6.3 next-20230505] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Chris-Leech/iscsi-create-per-net-iscsi-netlink-kernel-sockets/20230507-073308 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next patch link: https://lore.kernel.org/r/20230506232930.195451-7-cleech%40redhat.com patch subject: [PATCH 06/11] iscsi: set netns for tcp and iser hosts config: powerpc-randconfig-r016-20230507 (https://download.01.org/0day-ci/archive/20230507/202305070938.QRjcW4tq-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project b0fb98227c90adf2536c9ad644a74d5e92961111) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc cross compiling tool for clang build # apt-get install binutils-powerpc-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/a287abe6fb8da0c4af44c1d83fad9ca4fcb7184f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Chris-Leech/iscsi-create-per-net-iscsi-netlink-kernel-sockets/20230507-073308 git checkout a287abe6fb8da0c4af44c1d83fad9ca4fcb7184f # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/scsi/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@...el.com> | Link: https://lore.kernel.org/oe-kbuild-all/202305070938.QRjcW4tq-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/scsi/scsi_transport_iscsi.c:234:1: warning: no previous prototype for function '__iscsi_create_endpoint' [-Wmissing-prototypes] __iscsi_create_endpoint(struct Scsi_Host *shost, int dd_size, struct net *net) ^ drivers/scsi/scsi_transport_iscsi.c:233:1: note: declare 'static' if the function is not intended to be used outside of this translation unit struct iscsi_endpoint * ^ static 1 warning generated. vim +/__iscsi_create_endpoint +234 drivers/scsi/scsi_transport_iscsi.c 232 233 struct iscsi_endpoint * > 234 __iscsi_create_endpoint(struct Scsi_Host *shost, int dd_size, struct net *net) 235 { 236 struct iscsi_endpoint *ep; 237 int err, id; 238 239 ep = kzalloc(sizeof(*ep) + dd_size, GFP_KERNEL); 240 if (!ep) 241 return NULL; 242 243 mutex_lock(&iscsi_ep_idr_mutex); 244 245 /* 246 * First endpoint id should be 1 to comply with user space 247 * applications (iscsid). 248 */ 249 id = idr_alloc(&iscsi_ep_idr, ep, 1, -1, GFP_NOIO); 250 if (id < 0) { 251 mutex_unlock(&iscsi_ep_idr_mutex); 252 printk(KERN_ERR "Could not allocate endpoint ID. Error %d.\n", 253 id); 254 goto free_ep; 255 } 256 mutex_unlock(&iscsi_ep_idr_mutex); 257 258 ep->id = id; 259 ep->dev.class = &iscsi_endpoint_class; 260 if (shost) 261 ep->dev.parent = &shost->shost_gendev; 262 if (net) 263 ep->netns = net; 264 dev_set_name(&ep->dev, "ep-%d", id); 265 err = device_register(&ep->dev); 266 if (err) 267 goto put_dev; 268 269 err = sysfs_create_group(&ep->dev.kobj, &iscsi_endpoint_group); 270 if (err) 271 goto unregister_dev; 272 273 if (dd_size) 274 ep->dd_data = &ep[1]; 275 return ep; 276 277 unregister_dev: 278 device_unregister(&ep->dev); 279 return NULL; 280 281 put_dev: 282 mutex_lock(&iscsi_ep_idr_mutex); 283 idr_remove(&iscsi_ep_idr, id); 284 mutex_unlock(&iscsi_ep_idr_mutex); 285 put_device(&ep->dev); 286 return NULL; 287 free_ep: 288 kfree(ep); 289 return NULL; 290 } 291 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
Powered by blists - more mailing lists