netdev - RE: [PATCH net-next 1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <PAXPR10MB5056C983DACCC8F0A883395E85719@PAXPR10MB5056.EURPRD10.PROD.OUTLOOK.COM>
Date: Mon, 8 May 2023 15:14:04 +0000
From: Peppe CAVALLARO <peppe.cavallaro@...com>
To: Teoh Ji Sheng <ji.sheng.teoh@...el.com>,
        "David S . Miller"
	<davem@...emloft.net>,
        Alexandre TORGUE - foss
	<alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>, Eric
 Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next 1/1] net: stmmac: xgmac: add ethtool per-queue
 irq statistic support

Hello

Idea behind the patch looks ok for me

Regards
peppe


ST Restricted

-----Original Message-----
From: Teoh Ji Sheng <ji.sheng.teoh@...el.com> 
Sent: Monday, May 8, 2023 4:44 PM
To: David S . Miller <davem@...emloft.net>; Peppe CAVALLARO <peppe.cavallaro@...com>; Alexandre TORGUE - foss <alexandre.torgue@...s.st.com>; Jose Abreu <joabreu@...opsys.com>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Maxime Coquelin <mcoquelin.stm32@...il.com>
Cc: netdev@...r.kernel.org; linux-stm32@...md-mailman.stormreply.com; linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Teoh Ji Sheng <ji.sheng.teoh@...el.com>
Subject: [PATCH net-next 1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support

Commit af9bf70154eb ("net: stmmac: add ethtool per-queue irq statistic
support") introduced ethtool per-queue statistics support to display number of interrupts generated by DMA tx and DMA rx for DWMAC4 core.
This patch extend the support to XGMAC core.

Signed-off-by: Teoh Ji Sheng <ji.sheng.teoh@...el.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
index dfd53264e036..070bd912580b 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
@@ -368,10 +368,12 @@ static int dwxgmac2_dma_interrupt(struct stmmac_priv *priv,
 
 		if (likely(intr_status & XGMAC_RI)) {
 			x->rx_normal_irq_n++;
+			x->rxq_stats[chan].rx_normal_irq_n++;
 			ret |= handle_rx;
 		}
 		if (likely(intr_status & (XGMAC_TI | XGMAC_TBU))) {
 			x->tx_normal_irq_n++;
+			x->txq_stats[chan].tx_normal_irq_n++;
 			ret |= handle_tx;
 		}
 	}
--
2.34.1