[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZFlbBsKLGjFPEtFp@localhost.localdomain>
Date: Mon, 8 May 2023 22:26:46 +0200
From: Michal Kubiak <michal.kubiak@...el.com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
CC: Vinod Koul <vkoul@...nel.org>, Giuseppe Cavallaro
<peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
Abeni" <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
Bhupesh Sharma <bhupesh.sharma@...aro.org>, <netdev@...r.kernel.org>,
<linux-stm32@...md-mailman.stormreply.com>,
<linux-arm-kernel@...ts.infradead.org>, <kernel@...gutronix.de>, Simon Horman
<simon.horman@...igine.com>
Subject: Re: [PATCH net-next v2 03/11] net: stmmac: dwmac-qcom-ethqos: Drop
an if with an always false condition
On Mon, May 08, 2023 at 04:26:29PM +0200, Uwe Kleine-König wrote:
> The remove callback is only ever called after .probe() returned
> successfully. After that get_stmmac_bsp_priv() always return non-NULL.
Nitpick: "always returns" or "will always return".
>
> Side note: The early exit would also be a bug because the return value
> of qcom_ethqos_remove() is ignored by the device core and the device is
> unbound unconditionally. So exiting early resulted in a dangerous
> resource leak as all devm allocated resources (some memory and the
> register mappings) are freed but the network device stays around. Using
> the network device afterwards probably oopses.
>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
Thanks,
Michal
Powered by blists - more mailing lists