lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230508061307.GB6195@unreal> Date: Mon, 8 May 2023 09:13:07 +0300 From: Leon Romanovsky <leonro@...dia.com> To: Tariq Toukan <tariqt@...dia.com> CC: <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, John Fastabend <john.fastabend@...il.com>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, "Paolo Abeni" <pabeni@...hat.com>, Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>, Tal Gilboa <talgi@...dia.com>, Roy Novich <royno@...dia.com>, Aya Levin <ayal@...dia.com> Subject: Re: [PATCH net] linux/dim: Do nothing if no time delta between samples On Sun, May 07, 2023 at 04:57:43PM +0300, Tariq Toukan wrote: > From: Roy Novich <royno@...dia.com> > > Add return value for dim_calc_stats. This is an indication for the > caller if curr_stats was assigned by the function. Avoid using > curr_stats uninitialized over {rdma/net}_dim, when no time delta between > samples. Coverity reported this potential use of an uninitialized > variable. > > Fixes: 4c4dbb4a7363 ("net/mlx5e: Move dynamic interrupt coalescing code to include/linux") > Fixes: cb3c7fd4f839 ("net/mlx5e: Support adaptive RX coalescing") > Signed-off-by: Roy Novich <royno@...dia.com> > Reviewed-by: Aya Levin <ayal@...dia.com> > Reviewed-by: Saeed Mahameed <saeedm@...dia.com> > Signed-off-by: Tariq Toukan <tariqt@...dia.com> > --- > include/linux/dim.h | 3 ++- > lib/dim/dim.c | 5 +++-- > lib/dim/net_dim.c | 3 ++- > lib/dim/rdma_dim.c | 3 ++- > 4 files changed, 9 insertions(+), 5 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@...dia.com>
Powered by blists - more mailing lists