netdev - Re: [PATCH net] ice: block LAN in case of VF to VF offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZFjXiYdUR5hDwjEi@localhost.localdomain>
Date: Mon, 8 May 2023 13:30:04 +0200
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Leon Romanovsky <leon@...nel.org>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
	kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
	netdev@...r.kernel.org,
	Sujai Buvaneswaran <Sujai.Buvaneswaran@...el.com>,
	George Kuruvinakunnel <george.kuruvinakunnel@...el.com>,
	Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH net] ice: block LAN in case of VF to VF offload

On Thu, May 04, 2023 at 10:42:49AM +0300, Leon Romanovsky wrote:
> On Wed, May 03, 2023 at 08:39:35AM -0700, Tony Nguyen wrote:
> > From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> > 
> > VF to VF traffic shouldn't go outside. To enforce it, set only the loopback
> > enable bit in case of all ingress type rules added via the tc tool.
> > 
> > Fixes: 0d08a441fb1a ("ice: ndo_setup_tc implementation for PF")
> > Reported-by: Sujai Buvaneswaran <Sujai.Buvaneswaran@...el.com>
> > Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> > Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@...el.com>
> > Reviewed-by: Simon Horman <simon.horman@...igine.com>
> > Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> > ---
> >  drivers/net/ethernet/intel/ice/ice_tc_lib.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/intel/ice/ice_tc_lib.c b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> > index 76f29a5bf8d7..d1a31f236d26 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> > @@ -693,17 +693,18 @@ ice_eswitch_add_tc_fltr(struct ice_vsi *vsi, struct ice_tc_flower_fltr *fltr)
> >  	 * results into order of switch rule evaluation.
> >  	 */
> >  	rule_info.priority = 7;
> > +	rule_info.flags_info.act_valid = true;
> 
> Do you still have path where rule_info.flags_info.act_valid = false?
> 

Good point, I will check if it is still needed.

Thanks

> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@...dia.com>