[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c77b8989fa4a1424a159fdd4450109a239babaa1.camel@redhat.com>
Date: Tue, 09 May 2023 11:30:15 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Lorenz Brun <lorenz@...n.one>, Felix Fietkau <nbd@....name>, John
Crispin <john@...ozen.org>, Sean Wang <sean.wang@...iatek.com>, Mark Lee
<Mark-MC.Lee@...iatek.com>, Lorenzo Bianconi <lorenzo@...nel.org>, "David
S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
Kicinski <kuba@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] net: ethernet: mtk_eth_soc: log clock enable errors
On Sun, 2023-05-07 at 23:40 +0200, Lorenz Brun wrote:
> Currently errors in clk_prepare_enable are silently swallowed.
> Add a log stating which clock failed to be enabled and what the error
> code was.
>
> Signed-off-by: Lorenz Brun <lorenz@...n.one>
> ---
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index e14050e17862..ca66a573cfcb 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -3445,8 +3445,10 @@ static int mtk_clk_enable(struct mtk_eth *eth)
>
> for (clk = 0; clk < MTK_CLK_MAX ; clk++) {
> ret = clk_prepare_enable(eth->clks[clk]);
> - if (ret)
> + if (ret) {
> + dev_err(eth->dev, "enabling clock %s failed with error %d\n", mtk_clks_source_name[clk], ret);
I'm sorry for nit-picking, but this lines really exceed any reasonable
max len. Please reformat the above as:
dev_err(eth->dev, "enabling clock %s failed with error %d\n",
mtk_clks_source_name[clk], ret);
Thanks!
Paolo
Powered by blists - more mailing lists