netdev - Re: [PATCH net-next 1/2] net: Keep sk->sk_forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZFoWM5YteJL2ZRxL@corigine.com>
Date: Tue, 9 May 2023 11:45:23 +0200
From: Simon Horman <simon.horman@...igine.com>
To: "Zhang, Cathy" <cathy.zhang@...el.com>
Cc: Jakub Kicinski <kuba@...nel.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Srinivas, Suresh" <suresh.srinivas@...el.com>,
	"Chen, Tim C" <tim.c.chen@...el.com>,
	"You, Lizhen" <lizhen.you@...el.com>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper
 size

On Tue, May 09, 2023 at 09:36:59AM +0000, Zhang, Cathy wrote:
> 
> 
> > -----Original Message-----
> > From: Simon Horman <simon.horman@...igine.com>
> > Sent: Tuesday, May 9, 2023 4:43 PM
> > To: Zhang, Cathy <cathy.zhang@...el.com>
> > Cc: Jakub Kicinski <kuba@...nel.org>; edumazet@...gle.com;
> > davem@...emloft.net; pabeni@...hat.com; Brandeburg, Jesse
> > <jesse.brandeburg@...el.com>; Srinivas, Suresh
> > <suresh.srinivas@...el.com>; Chen, Tim C <tim.c.chen@...el.com>; You,
> > Lizhen <lizhen.you@...el.com>; eric.dumazet@...il.com;
> > netdev@...r.kernel.org
> > Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper
> > size
> > 
> > On Tue, May 09, 2023 at 06:57:44AM +0000, Zhang, Cathy wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Jakub Kicinski <kuba@...nel.org>
> > > > Sent: Tuesday, May 9, 2023 10:06 AM
> > > > To: Zhang, Cathy <cathy.zhang@...el.com>
> > > > Cc: edumazet@...gle.com; davem@...emloft.net; pabeni@...hat.com;
> > > > Brandeburg, Jesse <jesse.brandeburg@...el.com>; Srinivas, Suresh
> > > > <suresh.srinivas@...el.com>; Chen, Tim C <tim.c.chen@...el.com>;
> > > > You, Lizhen <lizhen.you@...el.com>; eric.dumazet@...il.com;
> > > > netdev@...r.kernel.org
> > > > Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as
> > > > a proper size
> > > >
> > > > On Sun,  7 May 2023 19:08:00 -0700 Cathy Zhang wrote:
> > > > > Fixes: 4890b686f408 ("net: keep sk->sk_forward_alloc as small as
> > > > > possible")
> > > > >
> > > >
> > > > Ah, and for your future patches - no empty lines between trailers /
> > > > tags, please.
> > >
> > > Sorry, I do not quite get your point here. Do you mean there should be no
> > blanks between 'Fixes' line and 'Signed-off-by' line?
> > 
> > I'm not Jakub.
> 
> My apologies :-)

Sorry, what I meant here is: I think I know the answer. I could be
wrong, because I am a different person. But I'll try and answer anyway.

> > But, yes, I'm pretty sure that is what he means here.
> 
> Sure, I will pay attention to. For checkpatch.pl does not report error, I submit
> as it.

Yes, perhaps checkpatch.pl could be enhanced in this regard.