lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20230509013601.2544346-1-awkrail01@gmail.com> Date: Tue, 9 May 2023 10:36:01 +0900 From: Taichi Nishimura <awkrail01@...il.com> To: davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, bpf@...r.kernel.org, Taichi Nishimura <awkrail01@...il.com> Subject: [PATCH] add braces to rt_type == RTN_BROADCAST case Add braces to rt->rt_type == RTN_BROADCAST to make it easier to grasp the if-else-if statement. I think that it is ok to remove braces of rt_type == RTN_MULTICAST because IP_UPD_PO_STATS is oneliner. Signed-off-by: Taichi Nishimura <awkrail01@...il.com> --- net/ipv4/ip_output.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index 61892268e8a6..8b761e1a9e24 100644 --- a/net/ipv4/ip_output.c +++ b/net/ipv4/ip_output.c @@ -203,8 +203,9 @@ static int ip_finish_output2(struct net *net, struct sock *sk, struct sk_buff *s if (rt->rt_type == RTN_MULTICAST) { IP_UPD_PO_STATS(net, IPSTATS_MIB_OUTMCAST, skb->len); - } else if (rt->rt_type == RTN_BROADCAST) + } else if (rt->rt_type == RTN_BROADCAST) { IP_UPD_PO_STATS(net, IPSTATS_MIB_OUTBCAST, skb->len); + } if (unlikely(skb_headroom(skb) < hh_len && dev->header_ops)) { skb = skb_expand_head(skb, hh_len); -- 2.39.2
Powered by blists - more mailing lists