netdev - Re: [PATCH net-next v1 2/2] net: remove __skb_frag_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230509134123.GM38143@unreal>
Date: Tue, 9 May 2023 16:41:23 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Yunsheng Lin <linyunsheng@...wei.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v1 2/2] net: remove __skb_frag_set_page()

On Tue, May 09, 2023 at 07:43:37PM +0800, Yunsheng Lin wrote:
> The remaining users calling __skb_frag_set_page() with
> page being NULL seems to be doing defensive programming,
> as shinfo->nr_frags is already decremented, so remove
> them.
> 
> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>
> ---
> RFC: remove a local variable as pointed out by Simon.
> ---
>  drivers/net/ethernet/broadcom/bnx2.c      |  1 -
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c |  5 +----
>  include/linux/skbuff.h                    | 12 ------------
>  3 files changed, 1 insertion(+), 17 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>