netdev - Re: As usage of ethtool private flags is deprecated, what should we use from now on?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230509085021.3382222f@kernel.org>
Date: Tue, 9 May 2023 08:50:21 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Sokolowski, Jan" <jan.sokolowski@...el.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Jiri Pirko
 <jiri@...nulli.us>
Subject: Re: As usage of ethtool private flags is deprecated, what should we
 use from now on?

On Tue, 9 May 2023 11:15:57 +0000 Sokolowski, Jan wrote:
> So, as recently I've been trying to upstream a patch that would
> introduce a new private flag to i40e driver, I've received a note
> that, according to this reply from Jakub Kicinski
> (https://lore.kernel.org/netdev/20230207215643.43f76bdd@kernel.org/),
> the use of private flags is deprecated and is something that will not
> be accepted by upstream anymore. 

It has little to do with ethtool private flags being deprecated 
and a lot to do with how you were trying to use them. Andrew 
explains it well.

Maybe we should have called them "my device is weird flags", 
so people don't think they are "do whatever you want" flags :(