[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230509031200.2152236-1-liuhangbin@gmail.com>
Date: Tue, 9 May 2023 11:11:56 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: netdev@...r.kernel.org
Cc: Jay Vosburgh <j.vosburgh@...il.com>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Eric Dumazet <edumazet@...gle.com>,
Liang Li <liali@...hat.com>,
Vincent Bernat <vincent@...nat.ch>,
Simon Horman <simon.horman@...igine.com>,
Hangbin Liu <liuhangbin@...il.com>
Subject: [PATCHv3 net 0/4] bonding: fix send_peer_notif overflow
Bonding send_peer_notif was defined as u8. But the value is
num_peer_notif multiplied by peer_notif_delay, which is u8 * u32.
This would cause the send_peer_notif overflow.
Before the fix:
TEST: num_grat_arp (active-backup miimon num_grat_arp 10) [ OK ]
TEST: num_grat_arp (active-backup miimon num_grat_arp 20) [ OK ]
4 garp packets sent on active slave eth1
TEST: num_grat_arp (active-backup miimon num_grat_arp 30) [FAIL]
24 garp packets sent on active slave eth1
TEST: num_grat_arp (active-backup miimon num_grat_arp 50) [FAIL]
After the fix:
TEST: num_grat_arp (active-backup miimon num_grat_arp 10) [ OK ]
TEST: num_grat_arp (active-backup miimon num_grat_arp 20) [ OK ]
TEST: num_grat_arp (active-backup miimon num_grat_arp 30) [ OK ]
TEST: num_grat_arp (active-backup miimon num_grat_arp 50) [ OK ]
Hangbin Liu (4):
bonding: fix send_peer_notif overflow
Documentation: bonding: fix the doc of peer_notif_delay
selftests: forwarding: lib: add netns support for tc rule handle stats
get
kselftest: bonding: add num_grat_arp test
Documentation/networking/bonding.rst | 9 ++--
drivers/net/bonding/bond_netlink.c | 7 ++-
drivers/net/bonding/bond_options.c | 8 ++-
include/net/bonding.h | 2 +-
.../drivers/net/bonding/bond_options.sh | 50 +++++++++++++++++++
.../drivers/net/bonding/bond_topo_3d1c.sh | 2 +
tools/testing/selftests/net/forwarding/lib.sh | 3 +-
7 files changed, 73 insertions(+), 8 deletions(-)
--
2.38.1
Powered by blists - more mailing lists