netdev - RE: [PATCH 0/6] net: ethernet: efct Add x3 ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 9 May 2023 05:30:19 +0000
From: "Jain, Harsh (DCG-ENG)" <h.jain@....com>
To: Jakub Kicinski <kuba@...nel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>, "Lendacky,
 Thomas" <Thomas.Lendacky@....com>, "Rangoju, Raju" <Raju.Rangoju@....com>,
	"S-k, Shyam-sundar" <Shyam-sundar.S-k@....com>, "harshjain.prof@...il.com"
	<harshjain.prof@...il.com>, "Gangurde, Abhijit" <abhijit.gangurde@....com>,
	"Gupta, Puneet (DCG-ENG)" <puneet.gupta@....com>, "Agarwal, Nikhil"
	<nikhil.agarwal@....com>, "Reddy, tarak" <tarak.reddy@....com>, "Habets,
 Martin" <martin.habets@....com>, "Cascon, Pablo" <pablo.cascon@....com>,
	"Cree, Edward" <edward.cree@....com>
Subject: RE: [PATCH  0/6] net: ethernet: efct Add x3 ethernet driver

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Saturday, February 11, 2023 12:52 AM
> To: Jain, Harsh (DCG-ENG) <h.jain@....com>
> Cc: davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com; Lendacky, Thomas <Thomas.Lendacky@....com>;
> Rangoju, Raju <Raju.Rangoju@....com>; S-k, Shyam-sundar <Shyam-sundar.S-k@....com>; harshjain.prof@...il.com; Gangurde,
> Abhijit <abhijit.gangurde@....com>; Gupta, Puneet (DCG-ENG) <puneet.gupta@....com>; Agarwal, Nikhil
> <nikhil.agarwal@....com>; Reddy, tarak <tarak.reddy@....com>; netdev@...r.kernel.org
> Subject: Re: [PATCH 0/6] net: ethernet: efct Add x3 ethernet driver
> 
> 
> 
> On Fri, 10 Feb 2023 18:33:15 +0530 Harsh Jain wrote:
> > This patch series adds new ethernet network driver for Alveo X3522[1].
> > X3 is a low-latency NIC with an aim to deliver the lowest possible
> > latency. It accelerates a range of diverse trading strategies
> > and financial applications.
> 
> Please get this reviewed by people within AMD who know something
> about netdev. Ed, Martin, Alejandro, etc.. This driver seems to
> share similarities with SFC and you haven't even CCed them.
> 
> This pile a 23kLoC has the same issues the community has been
> raising in reviews of other drivers from your organization.
> We don't have the resources to be engaging with badly behaving,
> throw-the-code-over-the-wall-open-source vendors.
Thanks Jakub,
We will review this internally and get back with a new approach.