netdev - Re: [PATCH 0/6] bus: fsl-mc: Make remove function return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ednqx967.fsf@mail.lhotse>
Date: Tue, 09 May 2023 17:20:48 +1000
From: Michael Ellerman <mpe@...erman.id.au>
To: Li Yang <leoyang.li@....com>, Uwe Kleine-König
 <u.kleine-koenig@...gutronix.de>
Cc: "kvm@...r.kernel.org" <kvm@...r.kernel.org>, Gaurav Jain
 <gaurav.jain@....com>, Roy Pledge <roy.pledge@....com>, Ioana Ciornei
 <ioana.ciornei@....com>, Eric Dumazet <edumazet@...gle.com>, "Diana
 Madalina Craciun (OSS)" <diana.craciun@....nxp.com>, Stuart Yoder
 <stuyoder@...il.com>, Horia Geanta <horia.geanta@....com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Laurentiu Tudor
 <laurentiu.tudor@....com>, Richard Cochran <richardcochran@...il.com>,
 Pankaj Gupta <pankaj.gupta@....com>, Alex Williamson
 <alex.williamson@...hat.com>, "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>, Herbert Xu
 <herbert@...dor.apana.org.au>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, Vinod Koul <vkoul@...nel.org>,
 "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
 "kernel@...gutronix.de" <kernel@...gutronix.de>, "Y.B. Lu"
 <yangbo.lu@....com>, "dmaengine@...r.kernel.org"
 <dmaengine@...r.kernel.org>, "linuxppc-dev@...ts.ozlabs.org"
 <linuxppc-dev@...ts.ozlabs.org>, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 0/6] bus: fsl-mc: Make remove function return void

Li Yang <leoyang.li@....com> writes:
> On Mon, May 8, 2023 at 8:44 AM Uwe Kleine-König
> <u.kleine-koenig@...gutronix.de> wrote:
>>
>> Hello Leo,
>>
>> On Thu, Apr 13, 2023 at 08:00:04AM +0200, Uwe Kleine-König wrote:
>> > On Wed, Apr 12, 2023 at 09:30:05PM +0000, Leo Li wrote:
>> > > > On Fri, Mar 10, 2023 at 11:41:22PM +0100, Uwe Kleine-König wrote:
>> > > > > Hello,
>> > > > >
>> > > > > many bus remove functions return an integer which is a historic
>> > > > > misdesign that makes driver authors assume that there is some kind of
>> > > > > error handling in the upper layers. This is wrong however and
>> > > > > returning and error code only yields an error message.
>> > > > >
>> > > > > This series improves the fsl-mc bus by changing the remove callback to
>> > > > > return no value instead. As a preparation all drivers are changed to
>> > > > > return zero before so that they don't trigger the error message.
>> > > >
>> > > > Who is supposed to pick up this patch series (or point out a good reason for
>> > > > not taking it)?
>> > >
>> > > Previously Greg KH picked up MC bus patches.
>> > >
>> > > If no one is picking up them this time, I probably can take it through
>> > > the fsl soc tree.
>> >
>> > I guess Greg won't pick up this series as he didn't get a copy of it :-)
>> >
>> > Browsing through the history of drivers/bus/fsl-mc there is no
>> > consistent maintainer to see. So if you can take it, that's very
>> > appreciated.
>>
>> My mail was meant encouraging, maybe it was too subtile? I'll try again:
>>
>> Yes, please apply, that would be wonderful!
>
> Sorry for missing your previous email.  I will do that.  Thanks.

Does MAINTAINERS need updating?

It says:

QORIQ DPAA2 FSL-MC BUS DRIVER
M:	Stuart Yoder <stuyoder@...il.com>
M:	Laurentiu Tudor <laurentiu.tudor@....com>
L:	linux-kernel@...r.kernel.org
S:	Maintained
...
F:	drivers/bus/fsl-mc/

cheers