netdev - Re: [PATCHv2 net] selftests: bonding: delete unnecessary line.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <155bbdb3-0d74-f279-3c22-e62e06332c4e@blackwall.org>
Date: Tue, 9 May 2023 10:52:43 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Liang Li <liali@...hat.com>, netdev@...r.kernel.org
Cc: j.vosburgh@...il.com, Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [PATCHv2 net] selftests: bonding: delete unnecessary line.

On 09/05/2023 10:50, Liang Li wrote:
> "ip link set dev "$devbond1" nomaster"
> This line code in bond-eth-type-change.sh is unnecessary.
> Because $devbond1 was not added to any master device.
> 
> Fixes: 222c94ec0ad4("selftests: bonding: add tests for ether type changes")

It doesn't fix anything because there really isn't a bug. The test still runs
as expected with the line below.

> Signed-off-by: Liang Li <liali@...hat.com>
> Acked-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  .../selftests/drivers/net/bonding/bond-eth-type-change.sh        | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh b/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
> index 5cdd22048ba7..862e947e17c7 100755
> --- a/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
> +++ b/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
> @@ -53,7 +53,6 @@ bond_test_enslave_type_change()
>  	# restore ARPHRD_ETHER type by enslaving such device
>  	ip link set dev "$devbond2" master "$devbond0"
>  	check_err $? "could not enslave $devbond2 to $devbond0"
> -	ip link set dev "$devbond1" nomaster
>  
>  	bond_check_flags "$devbond0"
>  

I still think this patch should be targeted at net-next instead, the test
runs as expected with or without that line.