netdev - Re: [PATCH net-next] nfp: improve link modes reading process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230509081317.GI38143@unreal>
Date: Tue, 9 May 2023 11:13:17 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Louis Peens <louis.peens@...igine.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <simon.horman@...igine.com>, netdev@...r.kernel.org,
	oss-drivers@...igine.com
Subject: Re: [PATCH net-next] nfp: improve link modes reading process

On Tue, May 09, 2023 at 09:58:17AM +0200, Louis Peens wrote:
> From: Yinjun Zhang <yinjun.zhang@...igine.com>
> 
> Avoid reading link modes from management firmware every time when
> `ethtool_get_link_ksettings` is called, only communicate with
> management firmware when necessary like we do for eth_table info.
> 
> This change can ease the situation that when large number of vlan
> sub-interfaces are created and their information is requested by
> some monitoring process like PCP [1] through ethool ioctl frequently.
> 
> [1] https://pcp.io
> 
> Signed-off-by: Yinjun Zhang <yinjun.zhang@...igine.com>
> Acked-by: Simon Horman <simon.horman@...igine.com>
> Signed-off-by: Louis Peens <louis.peens@...igine.com>
> ---
>  .../ethernet/netronome/nfp/nfp_net_ethtool.c  | 32 +++++------
>  .../ethernet/netronome/nfp/nfpcore/nfp_nsp.h  |  7 ++-
>  .../netronome/nfp/nfpcore/nfp_nsp_eth.c       | 54 +++++++++----------
>  3 files changed, 45 insertions(+), 48 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>