netdev - Re: [PATCH net v2 4/4] Documentation: net/mlx5: Wrap notes in admonition blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZFtpLCrVYbTf1CSg@corigine.com>
Date: Wed, 10 May 2023 11:51:40 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Bagas Sanjaya <bagasdotme@...il.com>
Cc: Linux Networking <netdev@...r.kernel.org>,
	Remote Direct Memory Access Kernel Subsystem <linux-rdma@...r.kernel.org>,
	Linux Documentation <linux-doc@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Saeed Mahameed <saeedm@...dia.com>,
	Leon Romanovsky <leon@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>, Gal Pressman <gal@...dia.com>,
	Rahul Rameshbabu <rrameshbabu@...dia.com>,
	Maher Sanalla <msanalla@...dia.com>,
	Moshe Shemesh <moshe@...dia.com>, Tariq Toukan <tariqt@...dia.com>,
	Leon Romanovsky <leonro@...dia.com>
Subject: Re: [PATCH net v2 4/4] Documentation: net/mlx5: Wrap notes in
 admonition blocks

On Wed, May 10, 2023 at 10:54:15AM +0700, Bagas Sanjaya wrote:
> Wrap note paragraphs in note:: directive as it better fit for the
> purpose of noting devlink commands.
> 
> Fixes: f2d51e579359b7 ("net/mlx5: Separate mlx5 driver documentation into multiple pages")
> Fixes: cf14af140a5ad0 ("net/mlx5e: Add vnic devlink health reporter to representors")
> Reviewed-by: Leon Romanovsky <leonro@...dia.com>
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>

Hi,

I think you may have missed one 'NOTE:' around line 213.
Is that intentional?