netdev - Re: [PATCH net-next v1 1/2] net: introduce and use skb_frag_fill_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <198376b3-e515-28db-97a1-20e8905ac935@huawei.com>
Date: Wed, 10 May 2023 08:39:31 +0800
From: Yunsheng Lin <linyunsheng@...wei.com>
To: Paolo Abeni <pabeni@...hat.com>, Igor Russkikh <irusskikh@...vell.com>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Michael Chan <michael.chan@...adcom.com>,
	Raju Rangoju <rajur@...lsio.com>, Ajit Khaparde <ajit.khaparde@...adcom.com>,
	Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>, Somnath Kotur
	<somnath.kotur@...adcom.com>, Claudiu Manoil <claudiu.manoil@....com>,
	Dimitris Michailidis <dmichail@...gible.com>, Thomas Petazzoni
	<thomas.petazzoni@...tlin.com>, Saeed Mahameed <saeedm@...dia.com>, Leon
 Romanovsky <leon@...nel.org>, "Michael S. Tsirkin" <mst@...hat.com>, Jason
 Wang <jasowang@...hat.com>, Ronak Doshi <doshir@...are.com>, VMware
 PV-Drivers Reviewers <pv-drivers@...are.com>, Wei Liu <wei.liu@...nel.org>,
	Paul Durrant <paul@....org>, Alexei Starovoitov <ast@...nel.org>, Daniel
 Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Martin
 KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, Yonghong Song
	<yhs@...com>, John Fastabend <john.fastabend@...il.com>, KP Singh
	<kpsingh@...nel.org>, Stanislav Fomichev <sdf@...gle.com>, Hao Luo
	<haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, Boris Pismenny
	<borisp@...dia.com>, Steffen Klassert <steffen.klassert@...unet.com>, Herbert
 Xu <herbert@...dor.apana.org.au>
CC: <simon.horman@...igine.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v1 1/2] net: introduce and use
 skb_frag_fill_page_desc()

On 2023/5/9 18:07, Paolo Abeni wrote:
> On Tue, 2023-05-09 at 17:26 +0800, Yunsheng Lin wrote:
>> Most users use __skb_frag_set_page()/skb_frag_off_set()/
>> skb_frag_size_set() to fill the page desc for a skb frag.
>>
>> Introduce skb_frag_fill_page_desc() to do that.
>>
>> net/bpf/test_run.c does not call skb_frag_off_set() to
>> set the offset, "copy_from_user(page_address(page), ...)"
>> suggest that it is assuming offset to be initialized as
>> zero, so call skb_frag_fill_page_desc() with offset being
>> zero for this case.
>>
>> Also, skb_frag_set_page() is not used anymore, so remove
>> it.
>>
>> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>
> 
> The recipients list is very long, but you forgot to include the most
> relevant one: the netdev ML.

Thanks for the remainding.

> 
> Probably it's worth splitting this patch in a series with individual
> patches touching the net core and the specific device drivers, to that
> you could CC only the relevant recipients on each patch.

I was debugging the send_mail stript to see why the netdev ML was not
included, and ended up sending a few copy of this patchset forgeting
to use '--dry-run' option.

As there is a few Reviewed-by tags from community now, splitting this patch
might need to drop some Reviewed-by tags, which means some patch might
need re-reviewing, I am not sure it is worth splitting considering the
confusion caused by the above mistake.

Please let me know what do you think.
Thanks.