netdev - Re: [PATCH net-next] net: phylink: constify fwnode arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 10 May 2023 16:59:48 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phylink: constify fwnode arguments

On Wed, May 10, 2023 at 2:03 PM Russell King (Oracle)
<rmk+kernel@...linux.org.uk> wrote:
>
> Both phylink_create() and phylink_fwnode_phy_connect() do not modify
> the fwnode argument that they are passed, so lets constify these.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

Thank you!

> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
>  drivers/net/phy/phylink.c | 11 ++++++-----
>  include/linux/phylink.h   |  5 +++--
>  2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index a4111f1be375..cf53096047e6 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -708,7 +708,7 @@ static int phylink_validate(struct phylink *pl, unsigned long *supported,
>  }
>
>  static int phylink_parse_fixedlink(struct phylink *pl,
> -                                  struct fwnode_handle *fwnode)
> +                                  const struct fwnode_handle *fwnode)
>  {
>         struct fwnode_handle *fixed_node;
>         bool pause, asym_pause, autoneg;
> @@ -819,7 +819,8 @@ static int phylink_parse_fixedlink(struct phylink *pl,
>         return 0;
>  }
>
> -static int phylink_parse_mode(struct phylink *pl, struct fwnode_handle *fwnode)
> +static int phylink_parse_mode(struct phylink *pl,
> +                             const struct fwnode_handle *fwnode)
>  {
>         struct fwnode_handle *dn;
>         const char *managed;
> @@ -1441,7 +1442,7 @@ static void phylink_fixed_poll(struct timer_list *t)
>  static const struct sfp_upstream_ops sfp_phylink_ops;
>
>  static int phylink_register_sfp(struct phylink *pl,
> -                               struct fwnode_handle *fwnode)
> +                               const struct fwnode_handle *fwnode)
>  {
>         struct sfp_bus *bus;
>         int ret;
> @@ -1480,7 +1481,7 @@ static int phylink_register_sfp(struct phylink *pl,
>   * must use IS_ERR() to check for errors from this function.
>   */
>  struct phylink *phylink_create(struct phylink_config *config,
> -                              struct fwnode_handle *fwnode,
> +                              const struct fwnode_handle *fwnode,
>                                phy_interface_t iface,
>                                const struct phylink_mac_ops *mac_ops)
>  {
> @@ -1809,7 +1810,7 @@ EXPORT_SYMBOL_GPL(phylink_of_phy_connect);
>   * Returns 0 on success or a negative errno.
>   */
>  int phylink_fwnode_phy_connect(struct phylink *pl,
> -                              struct fwnode_handle *fwnode,
> +                              const struct fwnode_handle *fwnode,
>                                u32 flags)
>  {
>         struct fwnode_handle *phy_fwnode;
> diff --git a/include/linux/phylink.h b/include/linux/phylink.h
> index 71755c66c162..02c777ad18f2 100644
> --- a/include/linux/phylink.h
> +++ b/include/linux/phylink.h
> @@ -568,7 +568,8 @@ void phylink_generic_validate(struct phylink_config *config,
>                               unsigned long *supported,
>                               struct phylink_link_state *state);
>
> -struct phylink *phylink_create(struct phylink_config *, struct fwnode_handle *,
> +struct phylink *phylink_create(struct phylink_config *,
> +                              const struct fwnode_handle *,
>                                phy_interface_t iface,
>                                const struct phylink_mac_ops *mac_ops);
>  void phylink_destroy(struct phylink *);
> @@ -577,7 +578,7 @@ bool phylink_expects_phy(struct phylink *pl);
>  int phylink_connect_phy(struct phylink *, struct phy_device *);
>  int phylink_of_phy_connect(struct phylink *, struct device_node *, u32 flags);
>  int phylink_fwnode_phy_connect(struct phylink *pl,
> -                              struct fwnode_handle *fwnode,
> +                              const struct fwnode_handle *fwnode,
>                                u32 flags);
>  void phylink_disconnect_phy(struct phylink *);
>
> --
> 2.30.2
>


-- 
With Best Regards,
Andy Shevchenko