netdev - Re: mv88e6320: Failed to forward PTP multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230510182826.pxwiauia334vwvlh@skbuf>
Date: Wed, 10 May 2023 21:28:26 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Fabio Estevam <festevam@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, tobias@...dekranz.com,
	Florian Fainelli <f.fainelli@...il.com>,
	Steffen Bätz <steffen@...osonix.de>,
	netdev <netdev@...r.kernel.org>
Subject: Re: mv88e6320: Failed to forward PTP multicast

Hi Fabio,

On Wed, May 10, 2023 at 11:05:46AM -0300, Fabio Estevam wrote:
> On Fri, May 5, 2023 at 10:02 AM Andrew Lunn <andrew@...n.ch> wrote:
> 
> > I'm not too familiar with all this VLAN stuff. So i could be telling
> > your wrong information.... 'self' is also importing in way's i don't
> > really understand. Vladimir and Tobias are the experts here.
> 
> Vladimir and Tobias,
> 
> Would you have any suggestions as to how to allow PTP multicast to be
> forwarded when
> vlan_filtering is active?
> 
> The whole thread is at:
> https://lore.kernel.org/netdev/5cd6a70c-ea13-4547-958f-5806f86bfa10@lunn.ch/T/#m6453e569a98478bf5bddf09895393c3a52b91727
> 
> Thanks,
> 
> Fabio Estevam

I checked out the v6.1.26 tag from linux-stable and I was able to
synchronize 2 stations attached to my Turris MOX (Marvell 6190) with
this commands: sudo ptp4l -i eth0 -4 -m
(also I was able to synchronize a third station behind a mvneta bridge
port foreign to the MV88E6190, using software forwarding)

My bridge configuration is VLAN-aware. FWIW, I'm using vlan_default_pvid
1000, but it should not make a difference.

In a bridging configuration where there are only 2 ports in the bridge
PVID (1 source and 1 destination), could you please run the following
command from a station attached to one of the Marvell switch ports:

board # ethtool -S lanX | grep -v ': 0'
station # mausezahn eth0 -B 224.0.1.129 -c 1000 -t udp "dp=319"
board # ethtool -S lanX | grep -v ': 0'

and tell me which counters increment?

I am also curious whether there is any difference to your setup between:
ip link add br0 type bridge
ip link set br0 type bridge vlan_filtering 1 # dynamic toggling of VLAN awareness
and:
ip link add br0 type bridge vlan_filtering 1 # static creation of VLAN-aware bridge

I've tested both forms on my setup, and both work. Who knows, maybe
something happens differently on your particular kernel, or with your
particular switch model.

Is it vanilla v6.1.26 or something else?