netdev - Re: [PATCH net] ipv6: remove nexthop_fib6_nh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04db1f1b-eb81-6fd6-7696-ea217871815a@kernel.org>
Date: Wed, 10 May 2023 13:54:52 -0600
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com,
 syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH net] ipv6: remove nexthop_fib6_nh_bh()

On 5/10/23 9:46 AM, Eric Dumazet wrote:
> After blamed commit, nexthop_fib6_nh_bh() and nexthop_fib6_nh()
> are the same.
> 
> Delete nexthop_fib6_nh_bh(), and convert /proc/net/ipv6_route
> to standard rcu to avoid this splat:
> 

...

> 
> Fixes: 09eed1192cec ("neighbour: switch to standard rcu, instead of rcu_bh")
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  include/net/nexthop.h | 23 -----------------------
>  net/ipv6/ip6_fib.c    | 16 ++++++++--------
>  2 files changed, 8 insertions(+), 31 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>