lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <461cd40d-1576-419b-978e-1a195cd3531c@lunn.ch> Date: Wed, 10 May 2023 23:41:20 +0200 From: Andrew Lunn <andrew@...n.ch> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Cc: Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>, NXP Linux Team <linux-imx@....com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Fugang Duan <fugang.duan@....com>, Chuhong Yuan <hslester96@...il.com>, netdev@...r.kernel.org, kernel@...gutronix.de Subject: Re: [PATCH net] net: fec: Better handle pm_runtime_get() failing in .remove() On Wed, May 10, 2023 at 10:00:20PM +0200, Uwe Kleine-König wrote: > In the (unlikely) event that pm_runtime_get() (disguised as > pm_runtime_resume_and_get()) fails, the remove callback returned an > error early. The problem with this is that the driver core ignores the > error value and continues removing the device. This results in a > resource leak. Worse the devm allocated resources are freed and so if a > callback of the driver is called later the register mapping is already > gone which probably results in a crash. > > Fixes: a31eda65ba21 ("net: fec: fix clock count mis-match") > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists