netdev - Re: [PATCH RFC net-next 1/7] net: sfp: add helper to modify signal states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZFy/lQC7rKT7Dde/@corigine.com>
Date: Thu, 11 May 2023 12:12:37 +0200
From: Simon Horman <simon.horman@...igine.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	Daniel Golle <daniel@...rotopia.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH RFC net-next 1/7] net: sfp: add helper to modify signal
 states

On Wed, May 10, 2023 at 12:23:16PM +0100, Russell King (Oracle) wrote:
> There are a couple of locations in the code where we modify
> sfp->state, and then call sfp_set_state(, sfp->state) to update
> the outputs/soft state to control the module. Provide a helper
> which takes a mask and new state so that this is encapsulated in
> one location.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Reviewed-by: Simon Horman <simon.horman@...igine.com>