lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZFzDZhOSXuJ2Yg35@corigine.com> Date: Thu, 11 May 2023 12:28:54 +0200 From: Simon Horman <simon.horman@...igine.com> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Cc: Byungho An <bh74.an@...sung.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, kernel@...gutronix.de Subject: Re: [PATCH net-next] net: samsung: sxgbe: Make sxgbe_drv_remove() return void On Thu, May 11, 2023 at 12:17:40PM +0200, Simon Horman wrote: > On Wed, May 10, 2023 at 10:02:47PM +0200, Uwe Kleine-König wrote: > > sxgbe_drv_remove() returned zero unconditionally, so it can be converted > > to return void without losing anything. The upside is that it becomes > > more obvious in its callers that there is no error to handle. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> > > Reviewed-by: Simon Horman <simon.horman@...igine.com> Sorry, minor nit. Perhaps the subject prefix should be 'net: sxgbe: ', for consistency. Or 'sxgbe: ' because the 'net: ' part is largely meaningless.
Powered by blists - more mailing lists